This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] libxc: correct dirty_bitmap bounce size i

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] libxc: correct dirty_bitmap bounce size in xc_hvm_track_dirty_vram
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 10 Nov 2010 20:10:20 -0800
Delivery-date: Wed, 10 Nov 2010 20:11:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Ian Campbell <ian.campbell@xxxxxxxxxx>
# Date 1289400966 0
# Node ID 388c44a636137ebed114ed314a5c599e5a467f9d
# Parent  b0fe8260cefa87d0237278dd4c9fae7113b459ea
libxc: correct dirty_bitmap bounce size in xc_hvm_track_dirty_vram

The size should be in bytes not 32-bit words. Fixes graphics
corruption issues for HVM guests due to bouncing too little data.

Also the dirty_bitmap buffer is output only and therefore only needs
bouncing in one direction.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
 tools/libxc/xc_misc.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r b0fe8260cefa -r 388c44a63613 tools/libxc/xc_misc.c
--- a/tools/libxc/xc_misc.c     Wed Nov 10 14:37:19 2010 +0000
+++ b/tools/libxc/xc_misc.c     Wed Nov 10 14:56:06 2010 +0000
@@ -423,7 +423,7 @@ int xc_hvm_track_dirty_vram(
     unsigned long *dirty_bitmap)
-    DECLARE_HYPERCALL_BOUNCE(dirty_bitmap, (nr+31) / 32, 
+    DECLARE_HYPERCALL_BOUNCE(dirty_bitmap, (nr+7) / 8, 
     DECLARE_HYPERCALL_BUFFER(struct xen_hvm_track_dirty_vram, arg);
     int rc;

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] libxc: correct dirty_bitmap bounce size in xc_hvm_track_dirty_vram, Xen patchbot-unstable <=