This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-4.0-testing] xsm: return unlabeled instead of faili

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.0-testing] xsm: return unlabeled instead of failing with ENOENT in get_page_sid
From: "Xen patchbot-4.0-testing" <patchbot-4.0-testing@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 17 Oct 2010 05:55:22 -0700
Delivery-date: Sun, 17 Oct 2010 05:57:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir@xxxxxxx>
# Date 1285340255 -3600
# Node ID c9f461d6ea1db06e3434f8c1a29f2568f2b45f54
# Parent  964ee203d13998fb1b246580a516bcb4d223e6b7
xsm: return unlabeled instead of failing with ENOENT in get_page_sid

It is better to return an unlabeled SID in the case where dsec is NULL
instead of bailing out with an error.

From: Daniel De Graaf <dgdegra@xxxxxxxxxxxxx>
Signed-off-by: Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>
xen-unstable changeset:   22207:20f139010445
xen-unstable date:        Wed Sep 22 18:26:01 2010 +0100
 xen/xsm/flask/hooks.c |    5 +----
 1 files changed, 1 insertion(+), 4 deletions(-)

diff -r 964ee203d139 -r c9f461d6ea1d xen/xsm/flask/hooks.c
--- a/xen/xsm/flask/hooks.c     Wed Sep 22 08:55:09 2010 +0100
+++ b/xen/xsm/flask/hooks.c     Fri Sep 24 15:57:35 2010 +0100
@@ -340,10 +340,7 @@ static int get_page_sid(struct page_info
             /*Pages are implicitly labeled by domain ownership!*/
             dsec = d->ssid;
-            if (dsec)
-                *sid = dsec->sid;
-            else
-                rc = -ENOENT;
+            *sid = dsec ? dsec->sid : SECINITSID_UNLABELED;

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.0-testing] xsm: return unlabeled instead of failing with ENOENT in get_page_sid, Xen patchbot-4.0-testing <=