WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-4.0-testing] Without this we leak an fd on each dom

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-4.0-testing] Without this we leak an fd on each domain shutdown and eventually run
From: "Xen patchbot-4.0-testing" <patchbot-4.0-testing@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 02 Aug 2010 03:25:16 -0700
Delivery-date: Mon, 02 Aug 2010 03:25:44 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1280744191 -3600
# Node ID 5ce32b6bf352176c00adf38bce63b3b539c32959
# Parent  296b08b02fc8bd05db80dc778ff73ca5b4dd121a
Without this we leak an fd on each domain shutdown and eventually run
out of file descriptors meaning new the console of new domains are not
logged.

Seems to have been accidentally removed in 16638:28921e83000b.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
xen-unstable changeset:   21818:9ccd024065c5
xen-unstable date:        Mon Jul 19 12:21:24 2010 +0100
---
 tools/console/daemon/io.c |    5 +++++
 1 files changed, 5 insertions(+)

diff -r 296b08b02fc8 -r 5ce32b6bf352 tools/console/daemon/io.c
--- a/tools/console/daemon/io.c Mon Aug 02 11:16:04 2010 +0100
+++ b/tools/console/daemon/io.c Mon Aug 02 11:16:31 2010 +0100
@@ -748,6 +748,11 @@ static void cleanup_domain(struct domain
 {
        domain_close_tty(d);
 
+       if (d->log_fd != -1) {
+               close(d->log_fd);
+               d->log_fd = -1;
+       }
+
        free(d->buffer.data);
        d->buffer.data = NULL;
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-4.0-testing] Without this we leak an fd on each domain shutdown and eventually run, Xen patchbot-4.0-testing <=