This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] Before this patch only log messages with

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] Before this patch only log messages with precisely priority
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 20 Jul 2010 01:45:13 -0700
Delivery-date: Tue, 20 Jul 2010 01:45:51 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Stefano Stabellini <sstabellini@xxxxxxxxxxxxx>
# Date 1279278656 -3600
# Node ID 91ce0b0953ca684cc11beceda6adcf5cdef7b1b3
# Parent  c4a83e3cc6b435cc559450bbcd8b2ba7a801964f
Before this patch only log messages with precisely priority
LOG_WARNING (or precisely LOG_DEBUG if -v) would be logged.

xenconsoled only actually logs using LOG_ERR and LOG_DEBUG so for the
most part we would have been logging absolutely nothing up until now.

Linux provides a LOG_UPTO macro but I'm not sure how portable that is
so I have opencoded the list of levels.

Do I get some sort of prize for fixing a bug introduced in 2005?

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>
 tools/console/daemon/main.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff -r c4a83e3cc6b4 -r 91ce0b0953ca tools/console/daemon/main.c
--- a/tools/console/daemon/main.c       Thu Jul 15 18:18:16 2010 +0100
+++ b/tools/console/daemon/main.c       Fri Jul 16 12:10:56 2010 +0100
@@ -73,7 +73,8 @@ int main(int argc, char **argv)
        bool is_interactive = false;
        int ch;
        int syslog_option = LOG_CONS;
-       int syslog_mask = LOG_WARNING;
+       int syslog_mask = 
+                         LOG_MASK(LOG_ALERT)|LOG_MASK(LOG_EMERG);
        int opt_ind = 0;
        char *pidfile = NULL;
@@ -89,7 +90,8 @@ int main(int argc, char **argv)
 #ifndef __sun__
                        syslog_option |= LOG_PERROR;
-                       syslog_mask = LOG_DEBUG;
+                       syslog_mask |= LOG_MASK(LOG_NOTICE)|LOG_MASK(LOG_INFO)| 
+                                     LOG_MASK(LOG_DEBUG);
                case 'i':
                        is_interactive = true;

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] Before this patch only log messages with precisely priority, Xen patchbot-unstable <=