This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] x86: return value of domain_pirq_to_irq()

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: return value of domain_pirq_to_irq() is signed
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 16 Jun 2010 00:15:26 -0700
Delivery-date: Wed, 16 Jun 2010 00:17:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1276604463 -3600
# Node ID b0f7f710f512aba0fca814467e4f5fe7b906ada3
# Parent  972b7e305138759d4ef42b75d5fe5c6fd2d2e30c
x86: return value of domain_pirq_to_irq() is signed

That value can, for forcibly unbound PIRQs, validly be negative, and
for the respective check to catch those cases (and prevent using these
negative values as array index), the respective variables must be of
signed type.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
 xen/arch/x86/irq.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -r 972b7e305138 -r b0f7f710f512 xen/arch/x86/irq.c
--- a/xen/arch/x86/irq.c        Tue Jun 15 13:20:43 2010 +0100
+++ b/xen/arch/x86/irq.c        Tue Jun 15 13:21:03 2010 +0100
@@ -875,7 +875,7 @@ struct irq_desc *domain_spin_lock_irq_de
 struct irq_desc *domain_spin_lock_irq_desc(
     struct domain *d, int pirq, unsigned long *pflags)
-    unsigned int irq;
+    int irq;
     unsigned long flags;
     struct irq_desc *desc;
@@ -1042,7 +1042,7 @@ static int pirq_acktype(struct domain *d
 static int pirq_acktype(struct domain *d, int pirq)
     struct irq_desc  *desc;
-    unsigned int irq;
+    int irq;
     irq = domain_pirq_to_irq(d, pirq);
     if ( irq <= 0 )

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: return value of domain_pirq_to_irq() is signed, Xen patchbot-unstable <=