[Xen-changelog] [xen-4.0-testing] x86 shadow: Avoid remove-all-shadows after shadow teardown

["Xen patchbot-4.0-testing" <patchbot-4.0-testing@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1274858773 -3600
# Node ID 0ba90243d8ef0714d5261762bf9c722226817b56
# Parent  5fe5361d58dad7082b777cd29e7e58ea0358bca9
x86 shadow: Avoid remove-all-shadows after shadow teardown

If dom0 alters the p2m of a domain that's being destroyed, we can end
up doing a remove-all-shadows after the shadow hash table has been
freed. Since no hash table implies no shadows, just return
immediately.

Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
xen-unstable changeset:   21453:5addb6cb16fd
xen-unstable date:        Wed May 26 08:01:21 2010 +0100
---
 xen/arch/x86/mm/shadow/common.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletion(-)

diff -r 5fe5361d58da -r 0ba90243d8ef xen/arch/x86/mm/shadow/common.c
--- a/xen/arch/x86/mm/shadow/common.c   Wed May 26 08:25:51 2010 +0100
+++ b/xen/arch/x86/mm/shadow/common.c   Wed May 26 08:26:13 2010 +0100
@@ -2173,8 +2173,13 @@ static void hash_foreach(struct vcpu *v,
     struct domain *d = v->domain;
     struct page_info *x;
 
+    ASSERT(shadow_locked_by_me(d));
+
+    /* Can be called via p2m code &c after shadow teardown. */
+    if ( unlikely(!d->arch.paging.shadow.hash_table) )
+        return;
+
     /* Say we're here, to stop hash-lookups reordering the chains */
-    ASSERT(shadow_locked_by_me(d));
     ASSERT(d->arch.paging.shadow.hash_walking == 0);
     d->arch.paging.shadow.hash_walking = 1;
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog