This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] x86: When failing smp_callin() properly c

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: When failing smp_callin() properly clean up before halting.
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 19 May 2010 15:05:12 -0700
Delivery-date: Wed, 19 May 2010 15:05:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1274305768 -3600
# Node ID 8114ea8495f07172077501af4af7755ea8e8b1d4
# Parent  b127760a4725041734f13092196970fbc1a002e0
x86: When failing smp_callin() properly clean up before halting.

In particular we must clear_local_APIC() else LAPIC NMI watchdog will
continue to fire and use a stack which no longer exists.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
 xen/arch/x86/smpboot.c |    2 ++
 1 files changed, 2 insertions(+)

diff -r b127760a4725 -r 8114ea8495f0 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c    Wed May 19 21:14:57 2010 +0100
+++ b/xen/arch/x86/smpboot.c    Wed May 19 22:49:28 2010 +0100
@@ -164,6 +164,8 @@ void smp_callin(void)
         extern void (*dead_idle) (void);
         printk("CPU%d: Failed to initialise HVM. Not coming online.\n", cpu);
         cpu_error = rc;
+        clear_local_APIC();
+        spin_debug_enable();

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: When failing smp_callin() properly clean up before halting., Xen patchbot-unstable <=