This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] Revert 21224:a7947fd90328 "xend: earlier

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] Revert 21224:a7947fd90328 "xend: earlier remove the backend of tapdisk device"
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 24 Apr 2010 06:15:12 -0700
Delivery-date: Sat, 24 Apr 2010 06:15:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1272008239 -3600
# Node ID 7f3eff15050cc940fe68634a3b0e315e69b395e0
# Parent  2b97855a629f1d79e1d075a6d2a8b569018b2094
Revert 21224:a7947fd90328 "xend: earlier remove the backend of tapdisk device"

Consensus is that this is not the correct fix.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
 tools/python/xen/xend/XendDomainInfo.py |    8 +-------
 1 files changed, 1 insertion(+), 7 deletions(-)

diff -r 2b97855a629f -r 7f3eff15050c tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Thu Apr 22 17:43:56 2010 +0100
+++ b/tools/python/xen/xend/XendDomainInfo.py   Fri Apr 23 08:37:19 2010 +0100
@@ -2408,13 +2408,8 @@ class XendDomainInfo:
     def _releaseDevices(self, suspend = False):
         """Release all domain's devices.  Nothrow guarantee."""
-        t = xstransact("%s/device" % self.vmpath)
         if self.image:
-                for dev in t.list('tap'):
-                    log.debug("Early removing %s", dev);
-                    self.getDeviceController('tap').destroyDevice(dev, True)
-                time.sleep(0.1)
                 log.debug("Destroying device model")
             except Exception, e:
@@ -2423,10 +2418,9 @@ class XendDomainInfo:
             log.debug("No device model")
         log.debug("Releasing devices")
+        t = xstransact("%s/device" % self.vmpath)
             for devclass in XendDevices.valid_devices():
-                if devclass is 'tap':
-                    continue
                 for dev in t.list(devclass):
                         log.debug("Removing %s", dev);

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] Revert 21224:a7947fd90328 "xend: earlier remove the backend of tapdisk device", Xen patchbot-unstable <=