This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] xend: Unbreak live migration with tapdisk

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] xend: Unbreak live migration with tapdisk2 after 20691:054042ba73b6
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 21 Jan 2010 01:20:23 -0800
Delivery-date: Thu, 21 Jan 2010 01:20:20 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1264064580 0
# Node ID aa00760933df035e001cbb636679444fe9198e77
# Parent  f300b53520d0b13696f6ca6669fff8ad54289817
xend: Unbreak live migration with tapdisk2 after 20691:054042ba73b6

vm.image does not exist at this point in the restore process.
I haven't looked at the memory_sharing code. It's likely something
better is needed to make that work across relocation.

Signed-off-by: Brendan Cully <brendan@xxxxxxxxx>
 tools/python/xen/xend/server/BlktapController.py |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r f300b53520d0 -r aa00760933df 
--- a/tools/python/xen/xend/server/BlktapController.py  Wed Jan 20 20:36:19 
2010 +0000
+++ b/tools/python/xen/xend/server/BlktapController.py  Thu Jan 21 09:03:00 
2010 +0000
@@ -198,7 +198,7 @@ class Blktap2Controller(BlktapController
                     self.deviceClass = 'tap2'
                     return devid
-        if self.vm.image.memory_sharing:
+        if self.vm.image and self.vm.image.memory_sharing:
             cmd = [ TAPDISK_BINARY, '-n', '%s:%s' % (params, file), '-s', '%d' 
% self.vm.getDomid() ]
             cmd = [ TAPDISK_BINARY, '-n', '%s:%s' % (params, file) ]

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] xend: Unbreak live migration with tapdisk2 after 20691:054042ba73b6, Xen patchbot-unstable <=