[Xen-changelog] [xen-unstable] xenstore: Fix memory leak in command 'xenstore rm'

[Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1261391988 0
# Node ID 1f315181731a74b295d5357c8514d040275cfbbf
# Parent  1a911fd65e52fe1a7fb40c797a603b867761264e
xenstore: Fix memory leak in command 'xenstore rm'

When option '-t' is used to do tidy remove, routine xs_directory()
will be called in order to check there are brother directories or not.
The returned pointer should be passed to free() after this check.

Signed-off-by: Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>
---
 tools/xenstore/xenstore_client.c |    6 ++++--
 1 files changed, 4 insertions(+), 2 deletions(-)

diff -r 1a911fd65e52 -r 1f315181731a tools/xenstore/xenstore_client.c
--- a/tools/xenstore/xenstore_client.c  Fri Dec 18 07:53:27 2009 +0000
+++ b/tools/xenstore/xenstore_client.c  Mon Dec 21 10:39:48 2009 +0000
@@ -343,8 +343,10 @@ perform(enum mode mode, int optind, int 
                         unsigned int num;
                         char ** list = xs_directory(xsh, xth, p, &num);
 
-                        if (list && num == 0) {
-                            goto again;
+                        if (list) {
+                            free(list);
+                            if (num == 0)
+                                goto again;
                         }
                     }
                 }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog