WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] libxl: Call to open() must specify mode w

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] libxl: Call to open() must specify mode with O_CREAT.
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 09 Nov 2009 14:45:09 -0800
Delivery-date: Mon, 09 Nov 2009 14:45:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1257806483 0
# Node ID 494ad84ad38c4a67bfc2d7bab3d2c786c24803df
# Parent  0d7fb1ab92f490c6c88c36312ce0bae439e4df55
libxl: Call to open() must specify mode with O_CREAT.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 tools/libxl/libxl.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 0d7fb1ab92f4 -r 494ad84ad38c tools/libxl/libxl.c
--- a/tools/libxl/libxl.c       Mon Nov 09 22:30:21 2009 +0000
+++ b/tools/libxl/libxl.c       Mon Nov 09 22:41:23 2009 +0000
@@ -509,7 +509,7 @@ int libxl_create_device_model(struct lib
         rename(logfile, logfile_new);
     }
     logfile = libxl_sprintf(ctx, "/var/log/xen/qemu-dm-%s.log", 
info->dom_name);
-    logfile_w = open(logfile, O_WRONLY|O_CREAT);
+    logfile_w = open(logfile, O_WRONLY|O_CREAT, 0644);
     null = open("/dev/null", O_RDONLY);
     pid = libxl_exec(ctx, null, logfile_w, logfile_w, info->device_model, 
args);
     close(null);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] libxl: Call to open() must specify mode with O_CREAT., Xen patchbot-unstable <=