This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [qemu-xen-3.4-testing] Improve block range checks

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [qemu-xen-3.4-testing] Improve block range checks
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Tue, 20 Oct 2009 05:07:00 -0700
Delivery-date: Tue, 20 Oct 2009 05:06:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
commit 91e7210bba6f6931056be9f04a3d97e4873f28ab
Author: Kevin Wolf <kwolf@xxxxxxxxxx>
Date:   Fri May 8 14:47:24 2009 +0200

    Improve block range checks
    This patch makes the range checks for block requests more strict: It fixes a
    potential integer overflow and checks for negative offsets. Also, it adds 
    check for compressed writes.
    Signed-off-by: Kevin Wolf <kwolf@xxxxxxxxxx>
    Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>
    (cherry picked from commit fbb7b4e0804d2168f24142eebf7552adde1968dc)
    (cherry picked from commit 8c20718dab7f1612dcc40fe478642cbc1102aa9b)
 block.c |    7 ++++++-
 1 files changed, 6 insertions(+), 1 deletions(-)

diff --git a/block.c b/block.c
index 3261225..69c6da5 100644
--- a/block.c
+++ b/block.c
@@ -559,7 +559,10 @@ static int bdrv_check_byte_request(BlockDriverState *bs, 
int64_t offset,
     len = bdrv_getlength(bs);
-    if ((offset + size) > len)
+    if (offset < 0)
+        return -EIO;
+    if ((offset > len) || (len - offset < size))
         return -EIO;
     return 0;
@@ -1209,6 +1212,8 @@ int bdrv_write_compressed(BlockDriverState *bs, int64_t 
        return -EIO;
     if (!drv->bdrv_write_compressed)
         return -ENOTSUP;
+    if (bdrv_check_request(bs, sector_num, nb_sectors))
+        return -EIO;
     return drv->bdrv_write_compressed(bs, sector_num, buf, nb_sectors);
generated by git-patchbot for /home/xen/git/qemu-xen-3.4-testing.git

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [qemu-xen-3.4-testing] Improve block range checks, Ian Jackson <=