This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [qemu-xen-unstable] allow logdirty commands while paused

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [qemu-xen-unstable] allow logdirty commands while paused (unbreaks 60dbe1+8f09f4)
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Wed, 23 Sep 2009 08:05:03 -0700
Delivery-date: Wed, 23 Sep 2009 08:05:25 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
commit 743edef44f1d0da792aeb38a33bf468a4596f730
Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date:   Wed Sep 23 15:07:47 2009 +0100

    allow logdirty commands while paused (unbreaks 60dbe1+8f09f4)
    60dbe1+8f09f4 breaks HVM live migration: 60dbe1 causes xc_save to
    attempt to disable logdirty mode while qemu is paused. 8f09f4 disables
    most commands, including logdirty, while the domain is paused. So
    xc_save times out waiting for qemu to respond to the logdirty disable
    command, and live migration fails. Logdirty commands issued while
    paused should not affect the stability of ioemu.
    Signed-off-by: Brendan Cully <brendan@xxxxxxxxx>
 xenstore.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/xenstore.c b/xenstore.c
index e091259..4dcc4d1 100644
--- a/xenstore.c
+++ b/xenstore.c
@@ -864,6 +864,11 @@ void xenstore_process_event(void *opaque)
         goto out;
+    if (!strcmp(vec[XS_WATCH_TOKEN], "logdirty")) {
+        xenstore_process_logdirty_event();
+        goto out;
+    }
     /* if we are paused don't process anything else */
     if (xen_pause_requested)
         goto out;
@@ -874,11 +879,6 @@ void xenstore_process_event(void *opaque)
-    if (!strcmp(vec[XS_WATCH_TOKEN], "logdirty")) {
-        xenstore_process_logdirty_event();
-        goto out;
-    }
     if (strncmp(vec[XS_WATCH_TOKEN], "hd", 2) ||
         strlen(vec[XS_WATCH_TOKEN]) != 3)
         goto out;
generated by git-patchbot for /home/xen/git/qemu-xen-unstable.git

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [qemu-xen-unstable] allow logdirty commands while paused (unbreaks 60dbe1+8f09f4), Ian Jackson <=