This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-3.4-testing] rombios: fix trying to boot from next

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-3.4-testing] rombios: fix trying to boot from next device
From: "Xen patchbot-3.4-testing" <patchbot-3.4-testing@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 02 Jun 2009 22:10:29 -0700
Delivery-date: Thu, 11 Jun 2009 08:04:48 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1243863756 -3600
# Node ID 23c0bd0819d6fc13b6d1c107a008c034574d0d5e
# Parent  f81c80a77620809777d6858831e24349768d4ce5
rombios: fix trying to boot from next device

If boot="ndc", rombios cannot try to boot next device.
Because rombios jump to the boot vector without pushing return
address, gPXE code and so on cannot return if it fail to boot.

Signed-off-by: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>
xen-unstable changeset:   19654:11b3b6fafc7b
xen-unstable date:        Wed May 27 11:19:38 2009 +0100
 tools/firmware/rombios/rombios.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -r f81c80a77620 -r 23c0bd0819d6 tools/firmware/rombios/rombios.c
--- a/tools/firmware/rombios/rombios.c  Mon Jun 01 14:42:03 2009 +0100
+++ b/tools/firmware/rombios/rombios.c  Mon Jun 01 14:42:36 2009 +0100
@@ -8362,8 +8362,8 @@ ASM_END
   /* Jump to the boot vector */
     mov  bp, sp
-//    push cs
-//    push #int18_handler
+    push cs
+    push #int18_handler
     ;; Build an iret stack frame that will take us to the boot vector.
     ;; iret pops ip, then cs, then flags, so push them in the opposite order.

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-3.4-testing] rombios: fix trying to boot from next device, Xen patchbot-3.4-testing <=