This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [qemu-xen-unstable] qemu-img-xen: Fix cow creation with

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [qemu-xen-unstable] qemu-img-xen: Fix cow creation with raw image backing files
From: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Date: Mon, 11 May 2009 09:55:17 -0700
Delivery-date: Thu, 11 Jun 2009 07:59:13 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
commit be598c20435f39f2d71f4b3d8d0489dd9e3af4ba
Author: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
Date:   Tue May 5 15:20:50 2009 +0100

    qemu-img-xen: Fix cow creation with raw image backing files
      dd if=/dev/zero of=raw_image count=100
      ./qemu-img-xen create -b raw_image -f qcow2 cow_image
    would fail because it would attempt to autodetect the format of
    base_image.  With this change, it works.  However,
      ./qemu-img-xen create -b cow_image -f qcow2 cow_image_2
    will now fail because we now always expect the backing file to be raw.
    Thanks to Xin Li and Dongxiao Xu for the bug report.
    Signed-off-by: Ian Jackson <ian.jackson@xxxxxxxxxxxxx>
 qemu-img.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c
index efbb9b6..46e6351 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -199,7 +199,7 @@ static BlockDriverState *bdrv_new_open(const char *filename,
         if (!drv)
             error("Unknown file format '%s'", fmt);
     } else {
-        drv = NULL;
+        drv = &bdrv_raw;
     if (bdrv_open2(bs, filename, BRDV_O_FLAGS, drv) < 0) {
         error("Could not open '%s'", filename);
generated by git-patchbot for /home/xen/git/qemu-xen-unstable.git

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [qemu-xen-unstable] qemu-img-xen: Fix cow creation with raw image backing files, Ian Jackson <=