WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-3.2-testing] Fix SCHEDOP_poll to avoid wakeup-waiti

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-3.2-testing] Fix SCHEDOP_poll to avoid wakeup-waiting race on interrupt delivery.
From: "Xen patchbot-3.2-testing" <patchbot-3.2-testing@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 17 Oct 2008 00:20:38 -0700
Delivery-date: Fri, 17 Oct 2008 00:21:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1224179705 -3600
# Node ID 0d59015f505d52de9c176db4114fac4e1618b700
# Parent  dfbf481940bb48c891fe2988721a02db05bb7d29
Fix SCHEDOP_poll to avoid wakeup-waiting race on interrupt delivery.

Race found by Jan Beulich.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
xen-unstable changeset:   18640:dc61548aa479
xen-unstable date:        Thu Oct 16 18:36:43 2008 +0100
---
 xen/common/schedule.c |    4 ++++
 1 files changed, 4 insertions(+)

diff -r dfbf481940bb -r 0d59015f505d xen/common/schedule.c
--- a/xen/common/schedule.c     Thu Oct 16 18:27:37 2008 +0100
+++ b/xen/common/schedule.c     Thu Oct 16 18:55:05 2008 +0100
@@ -354,6 +354,10 @@ static long do_poll(struct sched_poll *s
     /* Check for events /after/ setting flags: avoids wakeup waiting race. */
     smp_wmb();
 
+    rc = 0;
+    if ( local_events_need_delivery() )
+        goto out;
+
     for ( i = 0; i < sched_poll->nr_ports; i++ )
     {
         rc = -EFAULT;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-3.2-testing] Fix SCHEDOP_poll to avoid wakeup-waiting race on interrupt delivery., Xen patchbot-3.2-testing <=