WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-3.2-testing] xc_save/xc_restore: Fix wrong data typ

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-3.2-testing] xc_save/xc_restore: Fix wrong data type
From: "Xen patchbot-3.2-testing" <patchbot-3.2-testing@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 17 Oct 2008 00:20:24 -0700
Delivery-date: Fri, 17 Oct 2008 00:20:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1224177263 -3600
# Node ID 88fee130562746836819cf4e6088e5f4ba8b0c31
# Parent  da7ba13a646338713aee5d23c043f73bad9d420a
xc_save/xc_restore: Fix wrong data type

xc_interface_open() may return -1, but if we define xc_fd as unsigned
int, then -1 will be > 0.

Signed-off-by: Zhigang Wang <zhigang.x.wang@xxxxxxxxxx>
Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
xen-unstable changeset:   18510:694b7daa353c
xen-unstable date:        Wed Sep 17 14:16:02 2008 +0100
---
 tools/xcutils/xc_restore.c |    4 ++--
 tools/xcutils/xc_save.c    |    4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

diff -r da7ba13a6463 -r 88fee1305627 tools/xcutils/xc_restore.c
--- a/tools/xcutils/xc_restore.c        Thu Oct 16 18:12:57 2008 +0100
+++ b/tools/xcutils/xc_restore.c        Thu Oct 16 18:14:23 2008 +0100
@@ -18,9 +18,9 @@ int
 int
 main(int argc, char **argv)
 {
-    unsigned int xc_fd, io_fd, domid, store_evtchn, console_evtchn;
+    unsigned int domid, store_evtchn, console_evtchn;
     unsigned int hvm, pae, apic;
-    int ret;
+    int xc_fd, io_fd, ret;
     unsigned long store_mfn, console_mfn;
 
     if ( argc != 8 )
diff -r da7ba13a6463 -r 88fee1305627 tools/xcutils/xc_save.c
--- a/tools/xcutils/xc_save.c   Thu Oct 16 18:12:57 2008 +0100
+++ b/tools/xcutils/xc_save.c   Thu Oct 16 18:14:23 2008 +0100
@@ -171,8 +171,8 @@ int
 int
 main(int argc, char **argv)
 {
-    unsigned int xc_fd, io_fd, domid, maxit, max_f, flags; 
-    int ret;
+    unsigned int domid, maxit, max_f, flags; 
+    int xc_fd, io_fd, ret;
 
     if (argc != 6)
        errx(1, "usage: %s iofd domid maxit maxf flags", argv[0]);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-3.2-testing] xc_save/xc_restore: Fix wrong data type, Xen patchbot-3.2-testing <=