This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] ioemu: Disable format auto-probing in mon

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] ioemu: Disable format auto-probing in monitor command change
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 18 Jun 2008 04:10:17 -0700
Delivery-date: Wed, 18 Jun 2008 04:10:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1213778354 -3600
# Node ID 9493a853df9ef0c17c6fb12efdcc86c5d67c7e03
# Parent  a1c98534418bc09abc2fa970200248f6e4723127
ioemu: Disable format auto-probing in monitor command change

Format auto-probing of writable images is a security hole.  The last
known remaining instance is monitor command change.  Disable probing
there and use raw.  This breaks change for images in all other

Signed-off-by: Markus Armbruster <armbru@xxxxxxxxxx>
 tools/ioemu/monitor.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r a1c98534418b -r 9493a853df9e tools/ioemu/monitor.c
--- a/tools/ioemu/monitor.c     Wed Jun 18 09:38:11 2008 +0100
+++ b/tools/ioemu/monitor.c     Wed Jun 18 09:39:14 2008 +0100
@@ -387,7 +387,7 @@ static void do_change_block(const char *
     if (eject_device(bs, 0) < 0)
-    bdrv_open(bs, filename, 0);
+    bdrv_open2(bs, filename, 0, &bdrv_raw);
     if (bdrv_is_encrypted(bs)) {
         term_printf("%s is encrypted.\n", device);
         for(i = 0; i < 3; i++) {

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] ioemu: Disable format auto-probing in monitor command change, Xen patchbot-unstable <=