This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] x86: Fix S3 resume after creating an HVM

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: Fix S3 resume after creating an HVM guest.
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 10 Jun 2008 03:40:31 -0700
Delivery-date: Tue, 10 Jun 2008 03:41:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1213001474 -3600
# Node ID a40c23c25b0d54e950367c5dd5028bc19ed43618
# Parent  37392df51f0bde7ce847c3879b812d1ee0026541
x86: Fix S3 resume after creating an HVM guest.

If we don't use PIT, we should disable it at boot time and at S3
resuming. In Xen this is done by disable_pit_irq(), but this function
is used by __initcall(). After bootstrap it will be discarded and may be
overwritten. This usually results in S3 resuming failure.

Signed-off-by: Huacai Chen <huacai.chen@xxxxxxxxx>
Signed-off-by: Li Zhang <li.zhang@xxxxxxxxx>
 xen/arch/x86/time.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 37392df51f0b -r a40c23c25b0d xen/arch/x86/time.c
--- a/xen/arch/x86/time.c       Mon Jun 09 09:47:51 2008 +0100
+++ b/xen/arch/x86/time.c       Mon Jun 09 09:51:14 2008 +0100
@@ -999,7 +999,7 @@ void __init early_time_init(void)
     setup_irq(0, &irq0);
-static int __init disable_pit_irq(void)
+static int disable_pit_irq(void)
     if ( !using_pit && cpu_has_apic )

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: Fix S3 resume after creating an HVM guest., Xen patchbot-unstable <=