This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] Fix blkif.py for virsh start

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] Fix blkif.py for virsh start
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 05 Jun 2008 05:40:11 -0700
Delivery-date: Thu, 05 Jun 2008 05:40:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1212658229 -3600
# Node ID bbb4bb69efb25c15067ae7f294bd23f512081710
# Parent  5603534c62f922b0106f2291100fbf135d69d072
Fix blkif.py for virsh start

I defined a cdrom to a guest domain as follows.


When the guest domain was created by using xm create command, uname
of the cdrom was ''.  Then creating the guest domain succeeded.

[2008-06-03 15:23:41 xend.XendDomainInfo 25956] DEBUG
XendDomainInfo.create(['vm', ['name', 'rhel5.2ga_hvm_lvol1'],
['device', ['vbd', ['uname', ''], ['dev', 'hdc:cdrom'], ['mode',

But, when the guest domain was created by using virsh start command,
uname of the cdrom was None.  Then creating the guest domain failed.

[2008-06-03 15:22:10 xend.XendDomainInfo 25559] DEBUG
XendDomainInfo.create(['vm', ['name', 'rhel5.2ga_hvm_lvol1'],
['device', ['vbd', ['dev', 'hdc:cdrom'], ['mode', 'r']]],

This patch fixes to be able to create guest domains by both xm create
command and virsh start command.

"if uname is None:" --> "if uname == '':" --> "if not uname:"
   till CS#17625             current           by this patch

Signed-off-by: Masaki Kanno <kanno.masaki@xxxxxxxxxxxxxx>
 tools/python/xen/xend/server/blkif.py |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 5603534c62f9 -r bbb4bb69efb2 tools/python/xen/xend/server/blkif.py
--- a/tools/python/xen/xend/server/blkif.py     Tue Jun 03 09:41:19 2008 +0100
+++ b/tools/python/xen/xend/server/blkif.py     Thu Jun 05 10:30:29 2008 +0100
@@ -47,7 +47,7 @@ class BlkifController(DevController):
         except ValueError:
             dev_type = "disk"
-        if uname == '':
+        if not uname:
             if dev_type == 'cdrom':
                 (typ, params) = ("", "")

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] Fix blkif.py for virsh start, Xen patchbot-unstable <=