WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] Remove domain_pause()/domain_unpause() fr

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] Remove domain_pause()/domain_unpause() from SCHEDOP_remote_shutdown.
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Mon, 02 Jun 2008 11:10:11 -0700
Delivery-date: Mon, 02 Jun 2008 11:10:15 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1212400612 -3600
# Node ID b9879d7108259d685ad567cedeeb785b67ee28e6
# Parent  a4775034ef83946803eb6a61e0af33fb6971123f
Remove domain_pause()/domain_unpause() from SCHEDOP_remote_shutdown.

It is pointless and causes the hypervisor to hang if dom0 invokes this
hypercall on itself.

Signed-off-by: Keir Fraser <keir.fraser@xxxxxxxxxx>
---
 xen/common/schedule.c |    3 ---
 1 files changed, 3 deletions(-)

diff -r a4775034ef83 -r b9879d710825 xen/common/schedule.c
--- a/xen/common/schedule.c     Mon Jun 02 10:55:55 2008 +0100
+++ b/xen/common/schedule.c     Mon Jun 02 10:56:52 2008 +0100
@@ -503,10 +503,7 @@ ret_t do_sched_op(int cmd, XEN_GUEST_HAN
             return ret;
         }
 
-        /* domain_pause() prevens any further execution in guest context. */
-        domain_pause(d);
         domain_shutdown(d, (u8)sched_remote_shutdown.reason);
-        domain_unpause(d);
 
         rcu_unlock_domain(d);
         ret = 0;

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] Remove domain_pause()/domain_unpause() from SCHEDOP_remote_shutdown., Xen patchbot-unstable <=