This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] x86: Fix reboot failure after S3

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] x86: Fix reboot failure after S3
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 30 May 2008 11:00:35 -0700
Delivery-date: Fri, 30 May 2008 12:22:18 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1212050579 -3600
# Node ID 564c9be76aa496fda12923ffca5c4ca41a6c395f
# Parent  098c88335a74f05882e7221045a33da7499240d5
x86: Fix reboot failure after S3

"warm reset vector" is used to start APs. At booting time, it is set
by BP, and cleared after all APs have started. When do S3, similar work
need to do. However, when enable non-boot CPUs after S3, Xen just sets
this vector, but forgets to clear it after APs startup.

Signed-off-by: Huacai Chen <huacai.chen@xxxxxxxxx>
 xen/arch/x86/smpboot.c |    5 +++++
 1 files changed, 5 insertions(+)

diff -r 098c88335a74 -r 564c9be76aa4 xen/arch/x86/smpboot.c
--- a/xen/arch/x86/smpboot.c    Thu May 29 09:40:07 2008 +0100
+++ b/xen/arch/x86/smpboot.c    Thu May 29 09:42:59 2008 +0100
@@ -1391,6 +1391,11 @@ void enable_nonboot_cpus(void)
                panic("Not enough cpus");
+       /*
+        * Cleanup possible dangling ends after sleep...
+        */
+       smpboot_restore_warm_reset_vector();
 #else /* ... !CONFIG_HOTPLUG_CPU */
 int __cpu_disable(void)

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] x86: Fix reboot failure after S3, Xen patchbot-unstable <=