WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-3.2-testing] x86: Fix a typo in shadow_get_and_crea

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-3.2-testing] x86: Fix a typo in shadow_get_and_create_l1e().
From: "Xen patchbot-3.2-testing" <patchbot-3.2-testing@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 01 May 2008 03:00:53 -0700
Delivery-date: Thu, 01 May 2008 07:48:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1209633344 -3600
# Node ID 76815d93d8c9856c12905c5a463054ac01ec8722
# Parent  fa7cfe1d847a036da8f59a654444bd5683c41f9d
x86: Fix a typo in shadow_get_and_create_l1e().

The typo is benign because sh_page_fault() gates the call to
shadow_get_and_create_l1e() on an equivalent test.

Signed-off-by: Tim Deegan <tim.deegan@xxxxxxxxxx>
xen-unstable changeset:   17505:bc7ee2f93852b0ac1e644a5604dda223f12b8604
xen-unstable date:        Wed Apr 23 13:32:58 2008 +0100
---
 xen/arch/x86/mm/shadow/multi.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r fa7cfe1d847a -r 76815d93d8c9 xen/arch/x86/mm/shadow/multi.c
--- a/xen/arch/x86/mm/shadow/multi.c    Thu May 01 10:15:18 2008 +0100
+++ b/xen/arch/x86/mm/shadow/multi.c    Thu May 01 10:15:44 2008 +0100
@@ -2006,7 +2006,7 @@ static shadow_l1e_t * shadow_get_and_cre
         else 
         {
             /* Shadowing an actual guest l1 table */
-            if ( !mfn_valid(gw->l2mfn) ) return NULL; /* No guest page. */
+            if ( !mfn_valid(gw->l1mfn) ) return NULL; /* No guest page. */
             *sl1mfn = get_shadow_status(v, gw->l1mfn, SH_type_l1_shadow);
             if ( !mfn_valid(*sl1mfn) ) 
             {

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-3.2-testing] x86: Fix a typo in shadow_get_and_create_l1e()., Xen patchbot-3.2-testing <=