WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [linux-2.6.18-xen] Solarflare: adjust module_param() per

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [linux-2.6.18-xen] Solarflare: adjust module_param() permissions
From: "Xen patchbot-linux-2.6.18-xen" <patchbot-linux-2.6.18-xen@xxxxxxxxxxxxxxxxxxx>
Date: Thu, 21 Feb 2008 07:11:11 -0800
Delivery-date: Fri, 22 Feb 2008 07:35:31 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1203589243 0
# Node ID 3445e940a0e762a44a0bfd64940b15710cb03ef9
# Parent  8c8a097cae698dc0808bcbb66b3de423064b59a3
Solarflare: adjust module_param() permissions

Using permissions with bit 1 set (i.e. 0666) is prohibited on module
parameters on 2.6.20+.

Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
Signed-off-by: Kieran Mansley <kmansley@xxxxxxxxxxxxxx>
---
 drivers/xen/sfc_netback/accel.c           |    2 +-
 drivers/xen/sfc_netfront/accel_netfront.c |    4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff -r 8c8a097cae69 -r 3445e940a0e7 drivers/xen/sfc_netback/accel.c
--- a/drivers/xen/sfc_netback/accel.c   Wed Feb 20 18:05:47 2008 +0000
+++ b/drivers/xen/sfc_netback/accel.c   Thu Feb 21 10:20:43 2008 +0000
@@ -72,7 +72,7 @@ static struct notifier_block netback_acc
 
 
 unsigned sfc_netback_max_pages = NETBACK_ACCEL_DEFAULT_MAX_BUF_PAGES;
-module_param_named(max_pages, sfc_netback_max_pages, uint, 0666);
+module_param_named(max_pages, sfc_netback_max_pages, uint, 0644);
 MODULE_PARM_DESC(max_pages, 
                 "The number of buffer pages to enforce on each guest");
 
diff -r 8c8a097cae69 -r 3445e940a0e7 drivers/xen/sfc_netfront/accel_netfront.c
--- a/drivers/xen/sfc_netfront/accel_netfront.c Wed Feb 20 18:05:47 2008 +0000
+++ b/drivers/xen/sfc_netfront/accel_netfront.c Thu Feb 21 10:20:43 2008 +0000
@@ -235,11 +235,11 @@ struct netfront_accel_hooks accel_hooks 
 
 
 unsigned sfc_netfront_max_pages = NETFRONT_ACCEL_DEFAULT_BUF_PAGES;
-module_param_named (max_pages, sfc_netfront_max_pages, uint, 0666);
+module_param_named (max_pages, sfc_netfront_max_pages, uint, 0644);
 MODULE_PARM_DESC(max_pages, "Number of buffer pages to request");
 
 unsigned sfc_netfront_buffer_split = 2;
-module_param_named (buffer_split, sfc_netfront_buffer_split, uint, 0666);
+module_param_named (buffer_split, sfc_netfront_buffer_split, uint, 0644);
 MODULE_PARM_DESC(buffer_split, 
                 "Fraction of buffers to use for TX, rest for RX");
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [linux-2.6.18-xen] Solarflare: adjust module_param() permissions, Xen patchbot-linux-2.6.18-xen <=