This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] Handle netdev secondary addresses and lab

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] Handle netdev secondary addresses and labels
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 08 Jan 2008 15:10:10 -0800
Delivery-date: Tue, 08 Jan 2008 15:10:14 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir.fraser@xxxxxxxxxx>
# Date 1199785424 0
# Node ID 7b7700a30e5280d57ecb9a284ee943aa80ae37f0
# Parent  60440a7e7a40c0cfe94f7abcbde82ea2c6e123fe
Handle netdev secondary addresses and labels

Fix the network-bridge logic to correctly transfer secondary IP
address from $netdev to $bridge.

e.g. if you add an secondary address/label/alias with:

  $> ip addr add dev eth0 label eth0:00

then, "ip addr show dev eth0" gives e.g.:

  inet brd scope global eth0
  inet scope global secondary eth0:00

and transfer_addrs() tries to execute:

  ip addr add brd scope global dev tmpbridge
  ip addr add scope global secondary dev tmpbridge:00

which causes the sript to fail because:

  1) The device tmpbridge:00 doesn't exist
  2) The "secondary" flag isn't valid

This patch fixes the sed commands to instead give:

  ip addr add brd scope global dev tmpbridge label 
  ip addr add scope global dev tmpbridge label tmpbridge:00

Signed-off-by: Mark McLoughlin <markmc@xxxxxxxxxx>
 tools/examples/network-bridge |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -r 60440a7e7a40 -r 7b7700a30e52 tools/examples/network-bridge
--- a/tools/examples/network-bridge     Tue Jan 08 09:40:33 2008 +0000
+++ b/tools/examples/network-bridge     Tue Jan 08 09:43:44 2008 +0000
@@ -121,7 +121,8 @@ transfer_addrs () {
     ip addr show dev ${src} | egrep '^ *inet ' | sed -e "
 s/inet/ip addr add/
-s/${src}/dev ${dst}/
+s/${src}/dev ${dst} label ${dst}/
 " | sh -e
     # Remove automatic routes on destination device
     ip route list | sed -ne "

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] Handle netdev secondary addresses and labels, Xen patchbot-unstable <=