[Xen-changelog] [linux-2.6.18-xen] [IA64] backport Kexec/Kdump: honour non-zero crashkernel offset

["Xen patchbot-linux-2.6.18-xen" <patchbot-linux-2.6.18-xen@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Alex Williamson <alex.williamson@xxxxxx>
# Date 1190924760 21600
# Node ID 2a29669d8be0747b25c181eaacc0a9278a96ca00
# Parent  d3f72c686185330ef5a577f19959703245eeca93
[IA64] backport Kexec/Kdump: honour non-zero crashkernel offset

From: Horms <horms@xxxxxxxxxxxx>
>From Linux upstream, commit ad1c3ba7e54fc38b119c1a7d5c98f9ffb8227fdb

There seems to be a value in both allowing the kernel to determine
the base offset of the crashkernel automatically and allowing
users's to sepcify it.

The old behaviour on ia64, which is still the current behaviour on
most architectures is for the user to always specify the address.
Recently ia64 was changed so that it is always automatically determined.

With this patch the kernel automatically determines the offset if
the supplied value is 0, otherwise it uses the value provided.

This should probably be backed by a documentation change.

Signed-Off-By: Simon Horman <horms@xxxxxxxxxxxx>
Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
---
 arch/ia64/kernel/setup.c |   14 ++++++++++----
 1 files changed, 10 insertions(+), 4 deletions(-)

diff -r d3f72c686185 -r 2a29669d8be0 arch/ia64/kernel/setup.c
--- a/arch/ia64/kernel/setup.c  Thu Sep 27 14:22:31 2007 -0600
+++ b/arch/ia64/kernel/setup.c  Thu Sep 27 14:26:00 2007 -0600
@@ -299,7 +299,7 @@ reserve_memory (void)
 
 #ifdef CONFIG_KEXEC
        /* crashkernel=size@offset specifies the size to reserve for a crash
-        * kernel.(offset is ingored for keep compatibility with other archs)
+        * kernel. If offset is 0, then it is determined automatically.
         * By reserving this memory we guarantee that linux never set's it
         * up as a DMA target.Useful for holding code to do something
         * appropriate after a kernel panic.
@@ -318,10 +318,16 @@ reserve_memory (void)
 #endif
                if (from) {
                        size = memparse(from + 12, &from);
+                       if (*from == '@')
+                               base = memparse(from+1, &from);
+                       else
+                               base = 0;
                        if (size) {
-                               sort_regions(rsvd_region, n);
-                               base = kdump_find_rsvd_region(size,
-                               rsvd_region, n);
+                               if (!base) {
+                                       sort_regions(rsvd_region, n);
+                                       base = kdump_find_rsvd_region(size,
+                                                               rsvd_region, n);
+                                       }
                                if (base != ~0UL) {
                                        rsvd_region[n].start =
                                                (unsigned long)__va(base);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog