This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] xentop: fix abnormal value cpu(%) when do

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] xentop: fix abnormal value cpu(%) when domain shutdown.
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 07 Aug 2007 05:30:33 -0700
Delivery-date: Tue, 07 Aug 2007 05:29:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1186473998 -3600
# Node ID ff2dae3ebb1de85229ef3067a0257316bcc78aab
# Parent  007a11317ce88ce348b620280f87e709ace855ba
xentop: fix abnormal value cpu(%) when domain shutdown.

If we test multiple domain create/shutdown many times.
sometimes abnormal values of cpu(%) are appeared.
This is because shutdown domain remove failure.
(in other words, memory corruption of struct )
This corruption makes abnormal cpu(%) values are shown xentop

Signed-off-by: Atsushi SAKAI <sakaia@xxxxxxxxxxxxxx>
 tools/xenstat/libxenstat/src/xenstat.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 007a11317ce8 -r ff2dae3ebb1d tools/xenstat/libxenstat/src/xenstat.c
--- a/tools/xenstat/libxenstat/src/xenstat.c    Tue Aug 07 09:04:44 2007 +0100
+++ b/tools/xenstat/libxenstat/src/xenstat.c    Tue Aug 07 09:06:38 2007 +0100
@@ -677,7 +677,7 @@ static void xenstat_prune_domain(xenstat
        /* shift entries following specified entry up by one */
        if (entry < node->num_domains) {
                xenstat_domain *domain = &node->domains[entry];
-               memmove(domain,domain+1,node->num_domains-entry);
+               memmove(domain,domain+1,(node->num_domains - entry) * 
sizeof(xenstat_domain) );
        /* zero out original last entry from node -- not

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] xentop: fix abnormal value cpu(%) when domain shutdown., Xen patchbot-unstable <=