This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [Xen-changelog] [xen-unstable] hvm: Sync SVM CR4 handlin

To: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] RE: [Xen-changelog] [xen-unstable] hvm: Sync SVM CR4 handling with VMX.
From: "Petersson, Mats" <Mats.Petersson@xxxxxxx>
Date: Thu, 28 Jun 2007 12:33:06 +0200
Delivery-date: Thu, 28 Jun 2007 03:31:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200706280100.l5S10Ara001642@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Ace5H9GWe9vOGd6URTGl9AY7I2RrHwAS0YNQ
Thread-topic: [Xen-changelog] [xen-unstable] hvm: Sync SVM CR4 handling with VMX.
> diff -r 5eec9a8825d4 -r 87d34c8c2fe1 xen/include/asm-x86/hvm/hvm.h
> --- a/xen/include/asm-x86/hvm/hvm.h   Wed Jun 27 20:08:21 2007 +0100
> +++ b/xen/include/asm-x86/hvm/hvm.h   Wed Jun 27 20:17:54 2007 +0100
> @@ -302,10 +302,17 @@ static inline int hvm_event_injection_fa
>      return hvm_funcs.event_injection_faulted(v);
>  }
> -/* These bits in the CR4 are owned by the host */
> +/* These bits in CR4 are owned by the host. */
>  #define HVM_CR4_HOST_MASK (mmu_cr4_features & \
>      (X86_CR4_VMXE | X86_CR4_PAE | X86_CR4_MCE))

VMXE is only for Intel, so being very picky, it shouldn't be in a HVM

I don't think it's a problem as, I doubt very much that AMD would use
this bit for anything in the future, as Intel has "occupied it", and
we're using a different way to enable SVM. 


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>