WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] [IA64] Remove RBS from vcpu_guest_context

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] [IA64] Remove RBS from vcpu_guest_context_regs
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Sat, 16 Jun 2007 05:40:58 -0700
Delivery-date: Sat, 16 Jun 2007 05:39:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Alex Williamson <alex.williamson@xxxxxx>
# Date 1180626346 21600
# Node ID 919d72f6dc45ca6f7b5b4103fd06abac6bf2b4b7
# Parent  2b14a1f22eecc73807578ceb78fa994449911d8b
[IA64] Remove RBS from vcpu_guest_context_regs

We need to address places where this is allocated on the stack before
growing the structure this large.

Signed-off-by: Alex Williamson <alex.williamson@xxxxxx>
---
 xen/include/public/arch-ia64.h            |   10 ++++++++++
 xen/include/public/foreign/reference.size |    4 ++--
 2 files changed, 12 insertions(+), 2 deletions(-)

diff -r 2b14a1f22eec -r 919d72f6dc45 xen/include/public/arch-ia64.h
--- a/xen/include/public/arch-ia64.h    Fri May 25 09:43:21 2007 -0600
+++ b/xen/include/public/arch-ia64.h    Thu May 31 09:45:46 2007 -0600
@@ -464,8 +464,18 @@ struct vcpu_guest_context_regs {
 
         struct vcpu_tr_regs tr;
 
+#if 0
+       /*
+        * The vcpu_guest_context structure is allocated on the stack in
+        * a few places.  With this array for RBS storage, that structure
+        * is a bit over 21k.  It looks like maybe we're blowing the stack
+        * and causing rather random looking failures on a couple systems.
+        * Remove since we're not actually using it for now.
+        */
+
         /* Note: loadrs is 2**14 bytes == 2**11 slots.  */
         unsigned long rbs[2048];
+#endif
 };
 
 struct vcpu_guest_context {
diff -r 2b14a1f22eec -r 919d72f6dc45 xen/include/public/foreign/reference.size
--- a/xen/include/public/foreign/reference.size Fri May 25 09:43:21 2007 -0600
+++ b/xen/include/public/foreign/reference.size Thu May 31 09:45:46 2007 -0600
@@ -8,8 +8,8 @@ xen_ia64_boot_param       |       -     
 xen_ia64_boot_param       |       -       -      96
 ia64_tr_entry             |       -       -      32
 vcpu_tr_regs              |       -       -     512
-vcpu_guest_context_regs   |       -       -   21872
-vcpu_guest_context        |    2800    5168   21904
+vcpu_guest_context_regs   |       -       -    5488
+vcpu_guest_context        |    2800    5168    5520
 arch_vcpu_info            |      24      16       0
 vcpu_time_info            |      32      32      32
 vcpu_info                 |      64      64      48

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] [IA64] Remove RBS from vcpu_guest_context_regs, Xen patchbot-unstable <=