This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] xend: Fix spurious store changes on renam

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] xend: Fix spurious store changes on rename/migrate
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 01 May 2007 07:50:14 -0700
Delivery-date: Tue, 01 May 2007 07:49:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1178011091 -3600
# Node ID 26643b7b48b90111701bced27808c37ca339e2bf
# Parent  1cfe47358f9f7eef158a97c77ca5031da0ce6ea5
xend: Fix spurious store changes on rename/migrate

_storeChanged() was incorrectly comparing a string to an sxpr, thus
always firing and causing unnecessary watches to be fired in the

Signed-off-by: John Levon <john.levon@xxxxxxx>
 tools/python/xen/xend/XendDomainInfo.py |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -r 1cfe47358f9f -r 26643b7b48b9 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Tue May 01 10:16:26 2007 +0100
+++ b/tools/python/xen/xend/XendDomainInfo.py   Tue May 01 10:18:11 2007 +0100
@@ -885,7 +885,7 @@ class XendDomainInfo:
         # Check whether image definition has been updated
         image_sxp = self._readVm('image')
-        if image_sxp and image_sxp != self.info.image_sxpr():
+        if image_sxp and image_sxp != sxp.to_string(self.info.image_sxpr()):
             changed = True

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] xend: Fix spurious store changes on rename/migrate, Xen patchbot-unstable <=