This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] hvm rombios: Fix int15, func 0x86 (udelay

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] hvm rombios: Fix int15, func 0x86 (udelay).
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 24 Apr 2007 10:50:21 -0700
Delivery-date: Tue, 24 Apr 2007 10:50:11 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1177413238 -3600
# Node ID f71d167a6c6d7038fedc3d748db334f8ebba6467
# Parent  a7bd11fd5b1b6f4a82135db09dfe654e8966fabe
hvm rombios: Fix int15, func 0x86 (udelay).
Was reading argument from wrong stack location with recent versions of
bcc. Doing the access from [bp] rather than [sp] is safer as the
former does not change all the time.
Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>
 tools/firmware/rombios/rombios.c |    7 ++-----
 1 files changed, 2 insertions(+), 5 deletions(-)

diff -r a7bd11fd5b1b -r f71d167a6c6d tools/firmware/rombios/rombios.c
--- a/tools/firmware/rombios/rombios.c  Tue Apr 24 12:12:48 2007 +0100
+++ b/tools/firmware/rombios/rombios.c  Tue Apr 24 12:13:58 2007 +0100
@@ -4157,15 +4157,12 @@ BX_DEBUG_INT15("int15 AX=%04x\n",regs.u.
       DX = regs.u.r16.dx;
-      sti
       ;; Get the count in eax
-      mov  bx, sp
       SEG SS
-        mov  ax, _int15_function.CX [bx]
+        mov  ax, .int15_function32.CX [bp]
       shl  eax, #16
       SEG SS
-        mov  ax, _int15_function.DX [bx]
+        mov  ax, .int15_function32.DX [bp]
       ;; convert to numbers of 15usec ticks
       mov ebx, #15

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] hvm rombios: Fix int15, func 0x86 (udelay)., Xen patchbot-unstable <=