WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] [xen-unstable] xen: No need for shadow_drop_references()

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] xen: No need for shadow_drop_references() in remove_page().
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 04 Apr 2007 17:40:09 -0700
Delivery-date: Wed, 04 Apr 2007 17:39:34 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Keir Fraser <keir@xxxxxxxxxxxxx>
# Date 1175723240 -3600
# Node ID 1ec1affb1b504bf03b40d208899db4feb9bb6427
# Parent  f4318c89291afa42cb087945c902d05e71a77dfb
xen: No need for shadow_drop_references() in remove_page().

Because:
    guest_physmap_remove_page()
 -> p2m_remove_page()
 -> set_p2m_entry()
 -> paging_write_p2m_entry()
 -> shadow_write_p2m_entry()

And shadow_write_p2m_entry() calls sh_remove_all_*() fns.

Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>
---
 xen/common/memory.c |    6 ------
 1 files changed, 6 deletions(-)

diff -r f4318c89291a -r 1ec1affb1b50 xen/common/memory.c
--- a/xen/common/memory.c       Wed Apr 04 21:49:04 2007 +0100
+++ b/xen/common/memory.c       Wed Apr 04 22:47:20 2007 +0100
@@ -173,12 +173,6 @@ int guest_remove_page(struct domain *d, 
     if ( test_and_clear_bit(_PGC_allocated, &page->count_info) )
         put_page(page);
 
-    if ( unlikely((page->count_info & PGC_count_mask) != 1) )
-    {
-        shadow_drop_references(d, page);
-        /* NB: still may have foreign references to the page at this stage */
-    }
-
     guest_physmap_remove_page(d, gmfn, mfn);
 
     put_page(page);

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] xen: No need for shadow_drop_references() in remove_page()., Xen patchbot-unstable <=