xen-changelog

[Top] [All Lists]

[Xen-changelog] [xen-unstable] hvm vpic: Fix IRQ priority calculation in

from [Xen patchbot-unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] [xen-unstable] hvm vpic: Fix IRQ priority calculation in 8259 device model.
From:	Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Fri, 16 Mar 2007 14:50:06 -0700
Delivery-date:	Fri, 16 Mar 2007 14:49:13 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User kfraser@xxxxxxxxxxxxxxxxxxxxx
# Date 1174061975 0
# Node ID 90d6fe6de04d14ed19f4797af751f8a9a7d94d13
# Parent  3a186e94f613371b4dfa98b8e0a8d5aaf0f0d681
hvm vpic: Fix IRQ priority calculation in 8259 device model.
The priority shift should be a right-rotation, not a left-rotation.

From: Trolle Selander <trolle.selander@xxxxxxxxx>
Signed-off-by: Keir Fraser <keir@xxxxxxxxxxxxx>
---
 xen/arch/x86/hvm/vpic.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff -r 3a186e94f613 -r 90d6fe6de04d xen/arch/x86/hvm/vpic.c
--- a/xen/arch/x86/hvm/vpic.c   Fri Mar 16 15:19:08 2007 +0000
+++ b/xen/arch/x86/hvm/vpic.c   Fri Mar 16 16:19:35 2007 +0000
@@ -54,8 +54,8 @@ static int vpic_get_priority(struct hvm_
     if ( mask == 0 )
         return VPIC_PRIO_NONE;
 
-    /* prio = ffs(mask ROL vpic->priority_add); */
-    asm ( "rol %%cl,%b1 ; bsf %1,%0"
+    /* prio = ffs(mask ROR vpic->priority_add); */
+    asm ( "ror %%cl,%b1 ; bsf %1,%0"
           : "=r" (prio) : "r" ((uint32_t)mask), "c" (vpic->priority_add) );
     return prio;
 }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] [xen-unstable] hvm vpic: Fix IRQ priority calculation in 8259 device model., Xen patchbot-unstable <=

Previous by Date:	[Xen-changelog] [xen-unstable] libxc: Explicitly reserve space for special pages in HVM memmap., Xen patchbot-unstable
Next by Date:	[Xen-changelog] [xen-unstable] Fix VM_metrics.get_vcpus_utilisation., Xen patchbot-unstable
Previous by Thread:	[Xen-changelog] [xen-unstable] libxc: Explicitly reserve space for special pages in HVM memmap., Xen patchbot-unstable
Next by Thread:	[Xen-changelog] [xen-unstable] Fix VM_metrics.get_vcpus_utilisation., Xen patchbot-unstable
Indexes:	[Date] [Thread] [Top] [All Lists]