[Xen-changelog] [xen-unstable] Catch exception from dumpCore when inside refreshShutdown.

[Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>]

# HG changeset patch
# User Ewan Mellor <ewan@xxxxxxxxxxxxx>
# Date 1168013509 0
# Node ID e81c9fc5b431c3667ce87e245768032d59ffc28a
# Parent  a22258c9fe759d9aee5d5eda5d309eea507da1eb
Catch exception from dumpCore when inside refreshShutdown.

Thanks to John Levon <levon@xxxxxxxxxxxxxxxxx> for diagnosis and suggesting the
fix.

Signed-off-by: Ewan Mellor <ewan@xxxxxxxxxxxxx>
---
 tools/python/xen/xend/XendDomainInfo.py |   12 ++++++++++--
 1 files changed, 10 insertions(+), 2 deletions(-)

diff -r a22258c9fe75 -r e81c9fc5b431 tools/python/xen/xend/XendDomainInfo.py
--- a/tools/python/xen/xend/XendDomainInfo.py   Fri Jan 05 15:57:23 2007 +0000
+++ b/tools/python/xen/xend/XendDomainInfo.py   Fri Jan 05 16:11:49 2007 +0000
@@ -972,7 +972,12 @@ class XendDomainInfo:
                 self._writeVm(LAST_SHUTDOWN_REASON, 'crash')
 
                 if xroot.get_enable_dump():
-                    self.dumpCore()
+                    try:
+                        self.dumpCore()
+                    except XendError:
+                        # This error has been logged -- there's nothing more
+                        # we can do in this context.
+                        pass
 
                 restart_reason = 'crash'
                 self._stateSet(DOM_STATE_HALTED)
@@ -1164,7 +1169,10 @@ class XendDomainInfo:
     #
 
     def dumpCore(self, corefile = None):
-        """Create a core dump for this domain.  Nothrow guarantee."""
+        """Create a core dump for this domain.
+
+        @raise: XendError if core dumping failed.
+        """
         
         try:
             if not corefile:

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog