This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] [xen-unstable] [POWERPC] start-cpu has no return code

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] [xen-unstable] [POWERPC] start-cpu has no return code
From: Xen patchbot-unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 15 Aug 2006 15:30:18 +0000
Delivery-date: Tue, 15 Aug 2006 08:34:03 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User Jimi Xenidis <jimix@xxxxxxxxxxxxxx>
# Node ID cdb24f869a564a5dcd89bd4a6816069124ef17d3
# Parent  3109eaa648e5bbde1faea82a893efc7c2bea7462
[POWERPC] start-cpu has no return code

According to this document:

 PowerPC Processor binding to: IEEE 1275-1994
 Standard for Boot (Initialization, Configuration) Firmware
 Revision: 2.1 (Approved Version)
 Date: November 6, 1996

The start-cpu client interface has the following signature:

  IN: nodeid, pc, arg
  OUT: none

This patch reflects that, and makes us stop seeing a bogus OF_FAILURE if
we do actually check the return code of of_start_cpu.  Tested on JS20
and JS21 blades.

Signed-off-by: Amos Waterland <apw@xxxxxxxxxx>
Signed-off-by: Hollis Blanchard <hollisb@xxxxxxxxxx>
 xen/arch/powerpc/boot_of.c |   11 +++++------
 1 files changed, 5 insertions(+), 6 deletions(-)

diff -r 3109eaa648e5 -r cdb24f869a56 xen/arch/powerpc/boot_of.c
--- a/xen/arch/powerpc/boot_of.c        Wed Aug 09 18:53:00 2006 -0400
+++ b/xen/arch/powerpc/boot_of.c        Fri Aug 11 13:30:48 2006 -0400
@@ -304,12 +304,11 @@ static int __init of_instance_to_path(in
 static int __init of_start_cpu(int cpu, u32 pc, u32 reg)
-    int rets[1] = { OF_FAILURE };
-    if ( of_call("start-cpu", 3, 0, rets, cpu, pc, reg) == OF_FAILURE )
-        return OF_FAILURE;
-    return rets[0];
+    int ret;
+    ret = of_call("start-cpu", 3, 0, NULL, cpu, pc, reg);
+    return ret;
 static void __init of_test(const char *of_method_name)

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] [xen-unstable] [POWERPC] start-cpu has no return code, Xen patchbot-unstable <=