This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] Since we don't reset the proto_csum_blank flag in the sk

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] Since we don't reset the proto_csum_blank flag in the skb, the
From: Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 14 Apr 2006 17:00:13 +0000
Delivery-date: Fri, 14 Apr 2006 10:01:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID 40b124e270ee0f7d4c9c2546655cd20399b36d57
# Parent  7b9dacaf3340931a7724964553901b15941ce0bb
Since we don't reset the proto_csum_blank flag in the skb, the
checksum calculation gets done twice, which is not twice as good as

With this patch, TCP/UDP checksum errors from dom0 are fixed, and
domUs can use TCP/UDP without turning off TX checksum offload.  Normal
non-VLAN bridged configs still work fine, tested with xm-test.

Signed-off-by: Jim Dykman <dykman@xxxxxxxxxx>

diff -r 7b9dacaf3340 -r 40b124e270ee linux-2.6-xen-sparse/net/core/dev.c
--- a/linux-2.6-xen-sparse/net/core/dev.c       Fri Apr 14 13:21:12 2006
+++ b/linux-2.6-xen-sparse/net/core/dev.c       Fri Apr 14 13:23:40 2006
@@ -1294,6 +1294,7 @@
                if ((skb->h.raw + skb->csum + 2) > skb->tail)
                        goto out_kfree_skb;
                skb->ip_summed = CHECKSUM_HW;
+               skb->proto_csum_blank = 0;

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>