This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-changelog] These xm info, top, dmesg and log requre no parameter.

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] These xm info, top, dmesg and log requre no parameter.
From: Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Tue, 03 Jan 2006 17:10:14 +0000
Delivery-date: Tue, 03 Jan 2006 17:16:23 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User emellor@xxxxxxxxxxxxxxxxxxxxxx
# Node ID 09e752a1a04a1786b0b9d05113eab30da7b5c903
# Parent  9fc306e40a7cb7aad9115e2a2a6665f3a23ff96d
These xm info, top, dmesg and log requre no parameter.
But log's error message differs from other 3 command's error messages,
when parameter is given.

# xm log 1
Error: 'xm log' requires 0 argument.

   log                              Print the xend log

Other 3 commands ignore parameter.
I think it might be better symmetricalize.

Signed-off-by: Yoshinori Katase <y_katase@xxxxxxxxxxxxxxxx>

diff -r 9fc306e40a7c -r 09e752a1a04a tools/python/xen/xm/main.py
--- a/tools/python/xen/xm/main.py       Tue Jan  3 13:58:34 2006
+++ b/tools/python/xen/xm/main.py       Tue Jan  3 14:07:43 2006
@@ -625,6 +625,8 @@
     server.xend_domain_cpu_sedf_set(dom, *v)
 def xm_info(args):
+    arg_check(args, "info", 0)
     from xen.xend.XendClient import server
     info = server.xend_node()
@@ -645,9 +647,12 @@
 def xm_top(args):
+    arg_check(args, "top", 0)
     os.execvp('xentop', ['xentop'])
 def xm_dmesg(args):
+    arg_check(args, "dmesg", 0)
     gopts = Opts(use="""[-c|--clear]

Xen-changelog mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] These xm info, top, dmesg and log requre no parameter., Xen patchbot -unstable <=