xen-changelog

[Top] [All Lists]

[Xen-changelog] Free blkif if vbd_create fails.

from [Xen patchbot -unstable]

[Permanent Link][Original]

To:	xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-changelog] Free blkif if vbd_create fails.
From:	Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date:	Tue, 13 Sep 2005 19:44:11 +0000
Delivery-date:	Tue, 13 Sep 2005 19:42:39 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id:	BK change log <xen-changelog.lists.xensource.com>
List-post:	<mailto:xen-changelog@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to:	xen-devel@xxxxxxxxxxxxxxxxxxx
Sender:	xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx

# HG changeset patch
# User cl349@xxxxxxxxxxxxxxxxxxxx
# Node ID feff6bf0417ec3b6c7615fd47ac9c0085873fd15
# Parent  3a34bcb7c28b49877bbcf31fa3985ecb5651eae2
Free blkif if vbd_create fails.
Signed-off-by: Christian Limpach <Christian.Limpach@xxxxxxxxxxxx>

diff -r 3a34bcb7c28b -r feff6bf0417e 
linux-2.6-xen-sparse/drivers/xen/blkback/xenbus.c
--- a/linux-2.6-xen-sparse/drivers/xen/blkback/xenbus.c Tue Sep 13 19:09:44 2005
+++ b/linux-2.6-xen-sparse/drivers/xen/blkback/xenbus.c Tue Sep 13 19:43:58 2005
@@ -170,7 +170,6 @@
 
                be->blkif = alloc_blkif(be->frontend_id);
                if (IS_ERR(be->blkif)) {
-                        /* XXX SMH: should free blkif here... hmm */
                        err = PTR_ERR(be->blkif);
                        be->blkif = NULL;
                        xenbus_dev_error(dev, err, "creating block interface");
@@ -179,8 +178,8 @@
 
                err = vbd_create(be->blkif, handle, be->pdev, be->readonly);
                if (err) {
-                        /* XXX SMH: should free blkif here too... */
-                        be->blkif = NULL; 
+                       blkif_put(be->blkif);
+                       be->blkif = NULL;
                        xenbus_dev_error(dev, err, "creating vbd structure");
                        return;
                }

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-changelog] Free blkif if vbd_create fails., Xen patchbot -unstable <=

Previous by Date:	[Xen-changelog] Fix the logic in vcpu_sleep_sync(): we must wait until, Xen patchbot -unstable
Next by Date:	[Xen-changelog] Switch shutdown and sysrq to xstransact., Xen patchbot -unstable
Previous by Thread:	[Xen-changelog] Fix the logic in vcpu_sleep_sync(): we must wait until, Xen patchbot -unstable
Next by Thread:	[Xen-changelog] Switch shutdown and sysrq to xstransact., Xen patchbot -unstable
Indexes:	[Date] [Thread] [Top] [All Lists]