WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] Yes, that fixes the problem, our patches crossed. I saw

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] Yes, that fixes the problem, our patches crossed. I saw Keir already
From: Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Sun, 11 Sep 2005 16:36:11 +0000
Delivery-date: Sun, 11 Sep 2005 16:34:41 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID 4508c22dc45839721807753c373916c6601d74e9
# Parent  5721657e8130ac601eec7ae192e67f45e37f1125
Yes, that fixes the problem, our patches crossed. I saw Keir already
integrated my patch and while it is harmless, it is redundant and
here is the diff to take it out.

The patch also addresses some indent problems and aligns instructions
up with the rest of the block.

Signed-Off-By: Leendert van Doorn <leendert@xxxxxxxxxxxxxx>

diff -r 5721657e8130 -r 4508c22dc458 xen/arch/x86/vmx_io.c
--- a/xen/arch/x86/vmx_io.c     Sun Sep 11 16:34:38 2005
+++ b/xen/arch/x86/vmx_io.c     Sun Sep 11 16:36:24 2005
@@ -198,7 +198,6 @@
 static inline void __set_reg_value(unsigned long *reg, int size, long value)
 {
     switch (size) {
-        case BYTE:
         case BYTE_64:
             *reg &= ~0xFF;
             *reg |= (value & 0xFF);
diff -r 5721657e8130 -r 4508c22dc458 xen/arch/x86/vmx_platform.c
--- a/xen/arch/x86/vmx_platform.c       Sun Sep 11 16:34:38 2005
+++ b/xen/arch/x86/vmx_platform.c       Sun Sep 11 16:36:24 2005
@@ -55,7 +55,6 @@
 static inline long __get_reg_value(unsigned long reg, int size)
 {
     switch(size) {
-        case BYTE:
         case BYTE_64:
             return (char)(reg & 0xFF);
         case WORD:
@@ -90,10 +89,11 @@
                 return (char)((regs->rdx & 0xFF00) >> 8);
        case 7: /* %bh */
                 return (char)((regs->rbx & 0xFF00) >> 8);
-            default:
+       default:
            printf("Error: (get_reg_value) Invalid index value\n"); 
-                domain_crash_synchronous();
+           domain_crash_synchronous();
         }
+       /* NOTREACHED */
     }
 
     switch (index) {
@@ -114,8 +114,8 @@
         case 14: return __get_reg_value(regs->r14, size);
         case 15: return __get_reg_value(regs->r15, size);
         default:
-       printf("Error: (get_reg_value) Invalid index value\n"); 
-            domain_crash_synchronous();
+           printf("Error: (get_reg_value) Invalid index value\n"); 
+           domain_crash_synchronous();
     }
 }
 #elif defined (__i386__)

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] Yes, that fixes the problem, our patches crossed. I saw Keir already, Xen patchbot -unstable <=