WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-changelog

[Xen-changelog] xc_console is probably too chatty about termios failures

To: xen-changelog@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-changelog] xc_console is probably too chatty about termios failures since ssh
From: Xen patchbot -unstable <patchbot-unstable@xxxxxxxxxxxxxxxxxxx>
Date: Fri, 05 Aug 2005 05:02:10 -0400
Delivery-date: Fri, 05 Aug 2005 09:02:40 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-changelog-request@lists.xensource.com?subject=help>
List-id: BK change log <xen-changelog.lists.xensource.com>
List-post: <mailto:xen-changelog@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-changelog>, <mailto:xen-changelog-request@lists.xensource.com?subject=unsubscribe>
Reply-to: xen-devel@xxxxxxxxxxxxxxxxxxx
Sender: xen-changelog-bounces@xxxxxxxxxxxxxxxxxxx
# HG changeset patch
# User kaf24@xxxxxxxxxxxxxxxxxxxx
# Node ID f5a5e61f038ef7a4eb9180be94cbaba2487822a6
# Parent  38e6467df0e6116f7ea97ee77bf58a30a9dd70d6
xc_console is probably too chatty about termios failures since ssh 
sessions apparently don't have proper term settings.

Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>

diff -r 38e6467df0e6 -r f5a5e61f038e tools/consoled/xc_console.c
--- a/tools/consoled/xc_console.c       Fri Aug  5 08:59:41 2005
+++ b/tools/consoled/xc_console.c       Fri Aug  5 09:00:50 2005
@@ -78,23 +78,18 @@
        struct termios new_term;
 
        if (tcgetattr(fd, old) == -1) {
-               perror("tcgetattr() failed");
                return;
        }
 
        new_term = *old;
        cfmakeraw(&new_term);
 
-       if (tcsetattr(fd, TCSAFLUSH, &new_term) == -1) {
-               perror("tcsetattr() failed");
-       }
+       tcsetattr(fd, TCSAFLUSH, &new_term);
 }
 
 static void restore_term(int fd, struct termios *old)
 {
-       if (tcsetattr(fd, TCSAFLUSH, old) == -1) {
-               perror("tcsetattr() failed");
-       }
+       tcsetattr(fd, TCSAFLUSH, old);
 }
 
 static int console_loop(int xc_handle, domid_t domid, int fd)
@@ -113,7 +108,6 @@
                        if (errno == EINTR || errno == EAGAIN) {
                                continue;
                        }
-                       perror("select() failed");
                        return -1;
                }
 
@@ -131,7 +125,6 @@
                                    (errno == EINTR || errno == EAGAIN)) {
                                        continue;
                                }
-                               perror("select() failed");
                                return -1;
                        }
 
@@ -151,7 +144,6 @@
                                    (errno == EINTR || errno == EAGAIN)) {
                                        continue;
                                }
-                               perror("select() failed");
                                return -1;
                        }
 

_______________________________________________
Xen-changelog mailing list
Xen-changelog@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-changelog

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-changelog] xc_console is probably too chatty about termios failures since ssh, Xen patchbot -unstable <=