This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-bugs] [Bug 1686] New: regression: libxenstore leaks pipes

To: xen-bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-bugs] [Bug 1686] New: regression: libxenstore leaks pipes
From: bugzilla-daemon@xxxxxxxxxxxxxxxxxxx
Date: Wed, 10 Nov 2010 06:03:11 -0800
Delivery-date: Wed, 10 Nov 2010 06:03:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-bugs-request@lists.xensource.com?subject=help>
List-id: Xen Bugzilla <xen-bugs.lists.xensource.com>
List-post: <mailto:xen-bugs@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-bugs>, <mailto:xen-bugs-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-bugs>, <mailto:xen-bugs-request@lists.xensource.com?subject=unsubscribe>
Reply-to: bugs@xxxxxxxxxxxxxxxxxx
Sender: xen-bugs-bounces@xxxxxxxxxxxxxxxxxxx

           Summary: regression: libxenstore leaks pipes
           Product: Xen
           Version: unstable
          Platform: All
        OS/Version: Linux
            Status: NEW
          Severity: trivial
          Priority: P2
         Component: Tools
        AssignedTo: xen-bugs@xxxxxxxxxxxxxxxxxxx
        ReportedBy: jl@xxxxxx

Since cca xen-4.0.1rc5 (detailed commit info bellow) xenstore leaks 2 pipes and
one socket on each connection. It does not hurt if application is short-lived,
but it hurts libvirt daemon, which is supposed to run for prolonged period.

Steps to reproduce:
1. install xen-4.0.1rc5 or newer machine
2. install libvirt (tested with 0.7.6 and 0.8.1 to 0.8.4)
3. for i in `seq 1 1000`; do virsh -c xen:/// list; done
4. see lsof | grep libvirt

it will eventually die with too many files open (cca on i=330).

I have done git bisect and fond a commit which caused this regression:

8b490610757b1c81131c1876a54fd0bfec301c52 is first bad commit
commit 8b490610757b1c81131c1876a54fd0bfec301c52
Author: Keir Fraser <keir.fraser@xxxxxxxxxx>
Date:   Tue Jul 6 16:49:01 2010 +0100

    libxl: Backported stuff from unstable

    Signed-off-by: Gianni Tedesco <gianni.tedesco@xxxxxxxxxx>

Trivial patch solves this problem:
--- tools/xenstore/xs.c.orig    2010-11-10 13:18:05.000000000 +0000
+++ tools/xenstore/xs.c 2010-11-10 13:18:31.000000000 +0000
@@ -285,6 +285,7 @@
+       close_fds_free(h);

 static bool read_all(int fd, void *data, unsigned int len)

More info on this issue can be found in xen-users list in this thread:

Configure bugmail: 
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Xen-bugs mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-bugs] [Bug 1686] New: regression: libxenstore leaks pipes, bugzilla-daemon <=