This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-bugs] [Bug 1490] New: vif-common.sh frob_iptable() always logs ipta

To: xen-bugs@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-bugs] [Bug 1490] New: vif-common.sh frob_iptable() always logs iptables setup failed
From: bugzilla-daemon@xxxxxxxxxxxxxxxxxxx
Date: Fri, 7 Aug 2009 05:07:33 -0700
Delivery-date: Fri, 07 Aug 2009 05:07:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-bugs-request@lists.xensource.com?subject=help>
List-id: Xen Bugzilla <xen-bugs.lists.xensource.com>
List-post: <mailto:xen-bugs@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-bugs>, <mailto:xen-bugs-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-bugs>, <mailto:xen-bugs-request@lists.xensource.com?subject=unsubscribe>
Reply-to: bugs@xxxxxxxxxxxxxxxxxx
Sender: xen-bugs-bounces@xxxxxxxxxxxxxxxxxxx

           Summary: vif-common.sh frob_iptable() always logs iptables setup
           Product: Xen
           Version: unstable
          Platform: Other
        OS/Version: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Tools
        AssignedTo: xen-bugs@xxxxxxxxxxxxxxxxxxx
        ReportedBy: john.haxby@xxxxxxxxxx

During network setup, the frob_iptable() shell function is called and this
includes a check to make sure that the iptables commands invoked worked.

Unfortunately the test is always true:

   if [ "$command" == "online" ] && [ $? ]

The second test here is the one that fails: that form of the test is false if
$? is the empty string and true otherwise: as $? is a numeric exit status it is
always non-empty and so we always get the error logged.

Configure bugmail: 
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

Xen-bugs mailing list

<Prev in Thread] Current Thread [Next in Thread>