[Xen-bugs] [Bug 699] New: Unfriendly error messages in xm create

[bugzilla-daemon@xxxxxxxxxxxxxxxxxxx]

http://bugzilla.xensource.com/bugzilla/show_bug.cgi?id=699

           Summary: Unfriendly error messages in xm create
           Product: Xen
           Version: 3.0.1
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Tools
        AssignedTo: xen-bugs@xxxxxxxxxxxxxxxxxxx
        ReportedBy: o.pernet@xxxxxxxxx


The error messages in xm create are not really friendly at the moment. As an
example, inverting the memory size and domain name in xm mem-set outputs this :

>xm mem-set 1024 domainFoo
ignoring unknown unit
Unexpected error: exceptions.ValueError

Please report to xen-devel@xxxxxxxxxxxxxxxxxxx
Traceback (most recent call last):
  File "/usr/sbin/xm", line 10, in ?
    main.main(sys.argv)
  File "/var/tmp/xen-3.0.1-12.1_slc4.1-root/usr/lib/python/xen/xm/main.py",
line 906, in main
  File "/var/tmp/xen-3.0.1-12.1_slc4.1-root/usr/lib/python/xen/xm/main.py",
line 570, in xm_mem_set
  File "/var/tmp/xen-3.0.1-12.1_slc4.1-root/usr/lib/python/xen/xm/main.py",
line 270, in int_unit
ValueError: invalid literal for int(): domainFo

This is OK, but not really needed : the output should only inform the user that
it has inverted the parameters, that's all.
It gets worse if I use the domain ID instead of the name :

>xm mem-set 1024 41
Error: Domain '1024' not found when running 'xm mem-set'

Which doesn't tell the user at all that she inverted the parameters. But then,
a proper fix to that would probably involve adding command-line flags, which
you probably don't want since averybody is using this in their scripts already.

Regards,
-- Olivier


-- 
Configure bugmail: 
http://bugzilla.xensource.com/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

_______________________________________________
Xen-bugs mailing list
Xen-bugs@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-bugs