This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[XenARM] [PATCH] ns_write_reg() shall not return a value.

To: jm77.ryu@xxxxxxxxxxx
Subject: [XenARM] [PATCH] ns_write_reg() shall not return a value.
From: "Jean-Christophe DUBOIS" <jcd@xxxxxxxxxxxxxxx>
Date: Thu, 8 Sep 2011 23:15:08 +0200
Cc: xen-arm@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 08 Sep 2011 14:15:19 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-arm-request@lists.xensource.com?subject=help>
List-id: Xen ARM development <xen-arm.lists.xensource.com>
List-post: <mailto:xen-arm@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-arm>, <mailto:xen-arm-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-arm>, <mailto:xen-arm-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-arm-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.13.6 (Linux/2.6.38-11-generic; KDE/4.6.2; x86_64; ; )
This is a void function ... So make sure we don't return anything.

Signed-off-by: Jean-Christophe DUBOIS <jcd@xxxxxxxxxxxxxxx>
 xen/drivers/char/ns16550.c |    5 +++--
 1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c
index 8d376b8..46f1679 100644
--- a/xen/drivers/char/ns16550.c
+++ b/xen/drivers/char/ns16550.c
@@ -125,8 +125,9 @@ static char ns_read_reg(struct ns16550 *uart, int reg)
 static void ns_write_reg(struct ns16550 *uart, int reg, char c)
     if ( uart->remapped_io_base == NULL )
-        return outb(c, uart->io_base + reg);
-    writeb(c, uart->remapped_io_base + reg);
+        outb(c, uart->io_base + reg);
+    else
+        writeb(c, uart->remapped_io_base + reg);
 static void ns16550_interrupt(

Xen-arm mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • [XenARM] [PATCH] ns_write_reg() shall not return a value., Jean-Christophe DUBOIS <=