WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-api

[Xen-API] [PATCH 3 of 6] REBASE-4.1: vmops: apply CPUID to all domains

To: xen-devel@xxxxxxxxxxxxxxxxxxx, xen-api@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-API] [PATCH 3 of 6] REBASE-4.1: vmops: apply CPUID to all domains
From: Ian Campbell <ian.campbell@xxxxxxxxxx>
Date: Thu, 18 Nov 2010 10:50:25 +0000
Cc: Ian Campbell <ian.campbell@xxxxxxxxxx>
Delivery-date: Thu, 18 Nov 2010 03:09:09 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <patchbomb.1290077422@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
References: <patchbomb.1290077422@xxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.5.2
# HG changeset patch
# User root@xxxxxxxxxxxxxxxxxxxxx
# Date 1290076616 18000
# Node ID 810786855fe641b7db0074cfcb2b2a3a4dfd34a0
# Parent  4b9c3e5d05b045b4b93afa12e78afbef41ca7aa1
REBASE-4.1: vmops: apply CPUID to all domains.

Not just when xenclient is enabled.

I think the indentation was confusing here and the PCI passthrough bit wasn't
actually guarded by Xapi_globs.xenclient_enabled.

Required on newer hypervisor otherwise guest sees all cpuid leafs == 0.

Signed-off-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

diff -r 4b9c3e5d05b0 -r 810786855fe6 ocaml/xapi/vmops.ml
--- a/ocaml/xapi/vmops.ml       Thu Nov 18 05:36:56 2010 -0500
+++ b/ocaml/xapi/vmops.ml       Thu Nov 18 05:36:56 2010 -0500
@@ -1052,11 +1052,10 @@ let start_paused ?(progress_cb = fun _ -
 
                      let hvm = Helpers.is_hvm snapshot in                      
 
-                     if Xapi_globs.xenclient_enabled then 
-                       Domain.cpuid_apply ~xc ~hvm domid;
+                     Domain.cpuid_apply ~xc ~hvm domid;
 
-                         (* XXX: PCI passthrough needs a lot of work *)
-                         let pcidevs = (match pcidevs with Some x -> x | None 
-> pcidevs_of_vm ~__context ~vm) in
+                     (* XXX: PCI passthrough needs a lot of work *)
+                     let pcidevs = (match pcidevs with Some x -> x | None -> 
pcidevs_of_vm ~__context ~vm) in
 
                      (* Don't attempt to attach empty VBDs to PV guests: they 
can't handle them *)
                      let vbds = 

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api

<Prev in Thread] Current Thread [Next in Thread>