WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-api

[Xen-API] [PATCH] CA-43568: Fix copy/paste error in InterfaceReconfigure

To: <xen-api@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-API] [PATCH] CA-43568: Fix copy/paste error in InterfaceReconfigure.py
From: Alex Zeffertt <alex.zeffertt@xxxxxxxxxxxxx>
Date: Tue, 10 Aug 2010 10:39:40 +0100
Cc: alex.zeffertt@xxxxxxxxxxxxx
Delivery-date: Tue, 10 Aug 2010 02:39:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mercurial-patchbomb/1.4.3
# HG changeset patch
# User Alex Zeffertt <alex.zeffertt@xxxxxxxxxxxxx>
# Date 1281433108 -3600
# Node ID 9fe07c2469401dba691713841e1a806e589956e1
# Parent  2110a179e6a62119a520202d4e37e7a24b4fb9aa
CA-43568: Fix copy/paste error in InterfaceReconfigure.py

This was preventing the PIF.other-config:ethtool-duplex key being handled

Signed-off-by: Alex Zeffertt <alex.zeffertt@xxxxxxxxxxxxx>

diff -r 2110a179e6a6 -r 9fe07c246940 scripts/InterfaceReconfigure.py
--- a/scripts/InterfaceReconfigure.py   Tue Aug 10 10:38:28 2010 +0100
+++ b/scripts/InterfaceReconfigure.py   Tue Aug 10 10:38:28 2010 +0100
@@ -632,8 +632,8 @@
             log("Invalid value for ethtool-speed = %s. Must be 10|100|1000." % 
val)
     if oc.has_key('ethtool-duplex'):
         val = oc['ethtool-duplex']
-        if val in ["10", "100", "1000"]:
-            settings += ['duplex', 'val']
+        if val in ["half", "full"]:
+            settings += ['duplex', val]
         else:
             log("Invalid value for ethtool-duplex = %s. Must be half|full." % 
val)
     if oc.has_key('ethtool-autoneg'):

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-API] [PATCH] CA-43568: Fix copy/paste error in InterfaceReconfigure.py, Alex Zeffertt <=