WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-api

Re: [Xen-API] [PATCH] Just sanitizing indentation in stdext/listext.mli

To: <xen-api@xxxxxxxxxxxxxxxxxxx>, matthias Goergens <matthias.goergens@xxxxxxxxxx>, Jonathan Knowles <Jonathan.Knowles@xxxxxxxxxxxxx>
Subject: Re: [Xen-API] [PATCH] Just sanitizing indentation in stdext/listext.mli
From: Jonathan Knowles <jonathan.knowles@xxxxxxxxxxxxx>
Date: Tue, 16 Mar 2010 14:20:10 +0000
Cc:
Delivery-date: Tue, 16 Mar 2010 07:20:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <795ac4c3776bc0716c54.1268738919@matthias-desktop>
List-help: <mailto:xen-api-request@lists.xensource.com?subject=help>
List-id: Discussion of API issues surrounding Xen <xen-api.lists.xensource.com>
List-post: <mailto:xen-api@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-api>, <mailto:xen-api-request@lists.xensource.com?subject=unsubscribe>
References: <795ac4c3776bc0716c54.1268738919@matthias-desktop>
Sender: xen-api-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-GB; rv:1.9.1.5) Gecko/20091204 Lightning/1.0b1 Thunderbird/3.0
On 16/03/10 11:28, Matthias Goergens wrote:

Just sanitizing indentation in stdext/listext.mli

stdext/listext.mli |  32 ++++++++++++++++----------------
1 files changed, 16 insertions(+), 16 deletions(-)

Matthias

Unfortunately your patch changes the indendation away from
our coding standard, which says to use tab characters for
indendation (rather than spaces).

http://wiki.xensource.com/xenwiki/OCaml_Best_Practices says:

"A single level of indenting should consist of a single tab
character. Spaces should not be used. (Refer to Editing for
details of how to configure popular editors to conform to
this requirement.)"

Please could you modify this patch to indent with tabulation
characters instead of spaces?

Cheers,

Jonathan

_______________________________________________
xen-api mailing list
xen-api@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/mailman/listinfo/xen-api

<Prev in Thread] Current Thread [Next in Thread>