Re: [Xen-users] rebased opensuse 2.6.31 xen patches

[Boris Derzhavets <bderzhavets@xxxxxxxxx>]

> Weird, I can compile both 32 and 64 bit domU and dom0 without any
> errors like that, looking at the code I'd expect to hit that error
>straight away.

Applied V5 get same error building xenified 2.6.31.4
Spinlock-fix.patch allows compilation to start.


Boris.

--- On Fri, 10/23/09, Andrew Lyon <andrew.lyon@xxxxxxxxx> wrote:

From: Andrew Lyon <andrew.lyon@xxxxxxxxx>
Subject: Re: [Xen-users] rebased opensuse 2.6.31 xen patches
To: "Marco Nenciarini" <mnencia@xxxxxxxxxxxxxx>, "Jan Beulich" <jbeulich@xxxxxxxxxx>, "xen-users List" <xen-users@xxxxxxxxxxxxxxxxxxx>
Date: Friday, October 23, 2009, 7:28 AM

On Fri, Oct 23, 2009 at 12:03 PM, Marco Nenciarini
<mnencia@xxxxxxxxxxxxxx> wrote:
> Andrew Lyon ha scritto:
>>
>> On Fri, Oct 23, 2009 at 11:27 AM, Marco Nenciarini
>>
>> Thanks, does this fix a problem you have encountered? If so I would
>> like to see an example of the oops or warning you receive due to this
>> error.
>>
>> Andy
>
> Without that patch it does not compile at all.
>
>
> scripts/kconfig/conf -s arch/x86/Kconfig
>  Using
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen
> as source for kernel
>  GEN
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/Makefile
>  CHK     include/linux/version.h
>  UPD     include/linux/version.h
>  CHK     include/linux/utsrelease.h
>  UPD     include/linux/utsrelease.h
>  SYMLINK include/asm -> include/asm-x86
>  Updating
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/build_amd64_xen_amd64/scripts/Makefile.xen
>  CC      kernel/bounds.s
>  GEN     include/linux/bounds.h
>  CC      arch/x86/kernel/asm-offsets.s
> In file included from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/spinlock.h:88,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/seqlock.h:29,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/time.h:8,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/stat.h:60,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/module.h:10,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/include/linux/crypto.h:21,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets_64.c:7,
>                 from
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:4:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:134:
> error: expected identifier or ‘(’ before ‘:’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘}’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:138:
> error: expected identifier or ‘(’ before ‘while’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:
> In function ‘__ticket_spin_lock’:
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> error: expected ‘:’ or ‘)’ before ‘;’ token
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:217:
> warning: unused variable ‘tmp’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:227:
> error: expected ‘while’ before ‘static’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/kernel/asm-offsets.c:5:
> error: expected declaration or statement at end of input
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:215:
> warning: unused variable ‘free’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘count’
> /home/mnencia/deb/kernel/lab/linux-2.6-2.6.31/debian/build/source_amd64_xen/arch/x86/include/mach-xen/asm/spinlock.h:214:
> warning: unused variable ‘token’
> make[5]: *** [arch/x86/kernel/asm-offsets.s] Error 1
> make[4]: *** [prepare0] Error 2
>
> Marco
>
> --
> ---------------------------------------------------------------------
> |    Marco Nenciarini    | Debian/GNU Linux Developer - Plug Member |
> | mnencia@xxxxxxxxxxxxxx | http://www.prato.linux.it/~mnencia       |
> ---------------------------------------------------------------------
> Key fingerprint = FED9 69C7 9E67 21F5 7D95  5270 6864 730D F095 E5E4
>
>

Weird, I can compile both 32 and 64 bit domU and dom0 without any
errors like that, looking at the code I'd expect to hit that error
straight away.

I've CC'ed Jan and attached your patch to this message, he may want to
merge this upstream (or point out that I'm wrong again).

Andy

-----Inline Attachment Follows-----

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users

_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users