WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-users

RE: [Xen-users] qemu-dm crashing under 3.1

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: RE: [Xen-users] qemu-dm crashing under 3.1
From: "James Harper" <james.harper@xxxxxxxxxxxxxxxx>
Date: Fri, 15 Jun 2007 22:04:01 +1000
Cc: "Petersson, Mats" <Mats.Petersson@xxxxxxx>, xen-users@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 15 Jun 2007 05:02:09 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070615115423.GB4011@xxxxxxxxxx>
List-help: <mailto:xen-users-request@lists.xensource.com?subject=help>
List-id: Xen user discussion <xen-users.lists.xensource.com>
List-post: <mailto:xen-users@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-users>, <mailto:xen-users-request@lists.xensource.com?subject=unsubscribe>
References: <AEC6C66638C05B468B556EA548C1A77D01166AD8@trantor> <907625E08839C4409CE5768403633E0B02561E1B@xxxxxxxxxxxxxxxxx> <AEC6C66638C05B468B556EA548C1A77D01166AD9@trantor> <20070615115423.GB4011@xxxxxxxxxx>
Sender: xen-users-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcevQ/+Cy8IpTr50SyOZ/4N52IEc8QAAN9Yw
Thread-topic: [Xen-users] qemu-dm crashing under 3.1
> > The only thing that strikes me as odd is the value of ioh->fd...
isn't
> > that a little bit high for a fd number?
> 
> That looks like the VNC / event loop corruption bug Anthony & myself
fixed
> in upstream QEMU a few months back. You might want to give the
attached
> patch a go & see if it helps.
> 

The point I got to in looking through the code was that the vnc_read
function could close the fd and deallocate things before the second
FD_ISSET function... I assume that's what your patch fixes?

I can no longer make it crash with your patch applied, so I believe it
is fixed. Woohoo!

Could the same race condition occur in any other code paths? The other
crash I've seen appears to be similar but not related to the vnc
stuff...

Thanks!

James


_______________________________________________
Xen-users mailing list
Xen-users@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-users