WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-ppc-devel

Re: [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen] Add "#ifdef ARCH_

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Xen-changelog] [linux-2.6.18-xen] Add "#ifdef ARCH_HAS_DEV_MEM" to archtecture specific file_operations.
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Mon, 09 Jul 2007 14:41:04 -0500
Cc: Jun Kamada <kama@xxxxxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 09 Jul 2007 12:39:04 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2B84A7C.A8F1%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <C2B84A7C.A8F1%keir@xxxxxxxxxxxxx>
Reply-to: Hollis Blanchard <hollisb@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Mon, 2007-07-09 at 20:26 +0100, Keir Fraser wrote:
> On 9/7/07 20:20, "Hollis Blanchard" <hollisb@xxxxxxxxxx> wrote:
> 
> >> By the way, I wonder how PPC manages to build both drivers/char/mem.c and
> >> drivers/xen/char/mem.c without ARCH_HAS_DEV_MEM? The model is supposed to 
> >> be
> >> that mem_fops defined by the Xen file is picked up by the generic file. If
> >> !ARCH_HAS_DEV_MEM then that doesn't happen -- so who picks up the Xen
> >> mem_fops? 
> > 
> > Hmmm, yeah. Looks like we haven't tested that... :)
> 
> If you don't need to build both then there is potentially no problem with
> the Xen file hijacking the xlate_dev_mem() functions.

PowerPC Linux builds support for multiple platforms, including multiple
hypervisors, into a single binary (paravirt_ops was inspired by ppc_md).
For the most part our Xen patches continue this model, but because we
don't really test our Xen kernel on non-Xen platforms, there are a
couple bugs that would need fixing.

So compile-time ifdefs for /dev/mem won't work long-term, but I'm not
really worried about it.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel